Repository navigation
docs(systemd): the firewall unit stops justifying WorkingDirectory with a dependency that is gone - #621
Merged
Conversation
…th a dependency that is gone The comment said backup-firewall.sh resolves backups/firewall and .sops.yaml relative to the process's directory, and made WorkingDirectory= load-bearing for this unit in a way it is not for its siblings. That was true when written and stopped being true at d0e2556, which anchored both to the script's own repository so a hand-run export lands where backup-offsite.sh reads it. Nothing breaks either way — the directive is still set and still correct. What a stale justification costs is the next reader, who is told the opposite of how the script works and could reasonably undo the anchoring to match the comment. Replaced with the siblings' reason: the same value everywhere keeps the five units from disagreeing about where the repository is. Comment only, so there is nothing to deploy. The installed copy under /etc/systemd/system carries the old text until the next make install-timers, and systemd does not read comments. systemd-analyze verify passes; make validate passes. Refs #611. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The comment above
[Unit]insystemd/homelab-backup-firewall.service. Nothingelse — one comment, no directives touched.
Why
It justified
WorkingDirectory=with a dependency thatd0e2556removed:True when written. False since
#619 anchored both paths to the
script's own repository, which was the cause
#611 identified.
Nothing breaks either way — the directive is still set and still correct. What a
stale justification costs is the next reader, who is told the opposite of how the
script works, and who could reasonably undo the anchoring to make the code match
the comment. That would reintroduce #611's cause while looking like a tidy-up.
Replaced with the reason the siblings already give, quoted from
homelab-backup-volumes.service:29-30— "Same directive everywhere so the fiveunits cannot disagree about where the repository is" — so this unit stops
claiming a special case it no longer has.
Blast radius
secrets/*.sops.yamlComment only. systemd does not read comments, and no directive moved.
Verification
systemd-analyze verify systemd/homelab-backup-firewall.service— cleanmake validatepassesThe installed copy under
/etc/systemd/systemcarries the old text until thenext
make install-timers. That is cosmetic drift in a comment, not abehavioural difference, and nothing in
validatecompares installed unitsagainst this directory — so it is not worth a password on its own.
Found while confirming #619 was live on the monitoring host: the nightly unit
runs from
/home/robo/code/Gerrrt/HomeLab, that checkout is current, and theself-test there is 31 PASS / 0 FAIL — so the fix is live and only its
explanation was stale.
Refs #611.
🤖 Generated with Claude Code