Skip to content

docs(range): gandalf is ready for tpl-kali's build (#421, #790) - #1333

Merged
Gerrrt merged 3 commits into
mainfrom
gerrrt/gandalf-tpl-kali-prep
Nov 9, 2026
Merged

Gerrrt merged 3 commits into
mainfrom
gerrrt/gandalf-tpl-kali-prep

Conversation

@Gerrrt

@Gerrrt Gerrrt commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

What changed

gandalf is ready for tpl-kali's build (build-the-lab-templates.md §5, step 2's gandalf half). phoenix@pve now exists on gandalf, with PhoenixBuilder on /vms, /storage/range, /storage/local and vmbr0, and PVEAuditor on /nodes/gandalf. A PhoenixIsoCleanup grant on local was revoked after review, because Kali's build uploads no answer disc. The Kali 2026.2 installer is on gandalf's local, and kali_iso_file now defaults to it. The runbook records the grants and how phoenix should hold gandalf's token. The roadmap and changelog are updated.

Why

Refs #421 and #790. The roadmap names §5, the attack VM, as next. It clones tpl-kali, which Packer builds from phoenix through gandalf's own API. That API had no user, no role and no ISO.

Blast radius

gandalf only. It has no guests. The new user has no token yet, so nothing can authenticate as it. Its grants leave out local-lvm (ADR-0096 keeps range disks off the M.2) and vmbr1 (the range NIC belongs to the clone). They grant nothing under /nodes beyond audit, so the token cannot touch the host firewall. The role leaves out Saruman's Pool.*.

  • No change to network segmentation or firewall rules
  • No new port published to a VLAN that could not already reach the service
  • No credential added outside secrets/*.sops.yaml. No token was made. The runbook has the operator make it at the build, so its secret goes straight to phoenix.

Verification

Ran on gandalf, as root:

  • The API certificate: issuer PVE Cluster Manager CA, SANs include 10.0.30.30, no custom pveproxy-ssl.pem. Nothing was reissued.

  • pveum acl list | grep phoenix shows the five grants above. pveum role list shows PhoenixBuilder with the jumpbox list plus VM.GuestAgent.Audit, and no PhoenixIsoCleanup. pvesh get /nodes reads gandalf.

  • The ISO was downloaded from cdimage.kali.org and passed sha256sum -c against the hash pinned in scripts/collect-iso-store-state.sh. pvesm list local --content iso lists local:iso/kali-linux-2026.2-installer-amd64.iso.

  • Not run: the build, the smoke test and the -force rebuild. Those are Build tpl-kali (VMID 902) on ifrit once it exists #790's, from phoenix.

  • scripts/check_docs.py passes. make validate exits 0 with 43 checks skipped, because this host has no docker daemon and no pipx. That includes packer validate, shellcheck and markdownlint.

  • make validate passes (it passes with 43 skipped; see above)

  • Deployed to the lab and confirmed working (gandalf's user, grants and ISO, read back)

  • Docs updated (docs/, service README, or docs/roadmap.md)

🤖 Generated with Claude Code

phoenix@pve exists on gandalf with PhoenixBuilder on /vms, range, local
and vmbr0, PhoenixIsoCleanup on local and PVEAuditor on the node. Nothing
is granted on local-lvm or vmbr1. The Kali 2026.2 installer is on local,
checked against the pinned hash, and kali_iso_file defaults to it. No
token yet: it is made at the build.

Refs #421. Refs #790.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 9, 2026 04:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The runbook unnecessarily grants Gandalf datastore deletion and storage-configuration privileges for a Kali build that generates no answer disc.

2 open issues
What changed in this PR

Prepares gandalf for building the range’s tpl-kali template from phoenix. The template build and its verification remain outstanding under #790.

Changes:

  • Sets the Kali ISO default to the installer staged on gandalf.
  • Documents applied permissions, separate API credentials, CA trust, and the range storage override.
  • Records the preparation in the changelog and links the template build into the roadmap.
File Description
packer/​variables.pkr.hcl Updates the Kali ISO default and explanatory comment.
docs/​runbooks/​build-the-lab-templates.md Documents gandalf permissions and build setup.
docs/​roadmap.md Links the attack VM’s template-build dependency.
docs/​changelog.md Records completed host preparation and remaining verification.

Review effort: Balanced

@Gerrrt
Gerrrt enabled auto-merge (squash) November 9, 2026 04:37
Gerrrt and others added 2 commits November 8, 2026 21:28
… password (#790)

Refs #790.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Kali's build uploads no answer disc, so Datastore.Allocate on gandalf's
local bought nothing. The grant and the role are removed on gandalf.

Refs #790.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Gerrrt
Gerrrt merged commit 26f8037 into main Nov 9, 2026
14 of 17 checks passed
@Gerrrt
Gerrrt deleted the gerrrt/gandalf-tpl-kali-prep branch November 9, 2026 17:34
Gerrrt added a commit that referenced this pull request Nov 9, 2026
Resolves the conflicts with #1333, which recorded gandalf's half of
templates §5 step 2. Its text and table are kept, with this branch's
build results added. Where the two disagree on what gandalf holds, the
docs follow the token's live privileges: PhoenixBuilder on vmbr1 (used
by make-attack-vm.sh) and PhoenixIsoCleanup on local are both granted,
and the new changelog entry names the one it corrects.

Refs #421

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants