Repository navigation
feat(tofu,dotfiles): VirtIO GPU and a baked first sign-in for dot-windows (#1108) - #1112
Merged
Merged
Conversation
…ws (#1108) At the console, tester is a standard user, so each machine-wide install in the layer's configuration.dsc.yaml asked for the Administrator password. §3 now installs those packages before `clean` is taken: PowerShell 7, Git, WSL and Wireshark, each checked against its publisher's SHA-256. It also turns on Developer Mode and `winget configure`. §4 drops the steps those cover, and the OOBE workaround that #1093 made unnecessary. Done on 198 today; the as-run table and the changelog record it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…over SSH (#1108) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…1108) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… gerrrt/dot-windows-display
…dows (#1108) Two things made dot-windows slow, and neither was Saruman. Proxmox's default VGA has no Windows driver, so the guest drew every frame on the CPU as the Basic Display Adapter. The guest module gains a `vga` input, null by default, and dot-windows sets "virtio"; viogpudo is already in 911. And tester's first sign-in ran the CPU at 30-100% for 3.5-7.5 minutes, so §3 now signs it in once before `clean`, after which a sign-in settles in about 2 minutes. Both are applied to 198, and the as-run table and changelog record the measurements. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
7 tasks done
There was a problem hiding this comment.
🟢 Approval recommended
The infrastructure change is narrowly scoped, validated, applied successfully, and accompanied by complete operational guidance.
0 open findings
What changed in this PR
Adds VirtIO graphics and bakes the initial interactive sign-in into dot-windows, reducing console overhead and repeated startup work.
Changes:
- Adds an optional validated VGA setting to the guest module.
- Configures
dot-windowswith VirtIO GPU. - Documents prerequisite and first-sign-in baking, verification, and results.
| File | Description |
|---|---|
tofu/modules/guest/variables.tf |
Defines the optional VGA input. |
tofu/modules/guest/main.tf |
Conditionally configures the VGA block. |
tofu/guests.tf |
Enables VirtIO GPU for dot-windows. |
docs/runbooks/test-the-dotfiles-layers.md |
Documents baking and console procedures. |
docs/changelog.md |
Records the performance improvements. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…splay # Conflicts: # docs/changelog.md # docs/runbooks/test-the-dotfiles-layers.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers #1108's "look at the slowness". Saruman isn't the cause. The guest was slow for two reasons, and both are fixed and applied to
dot-windows(198).What I measured
Ruled out:
Found:
testerhad never signed in interactively. Its first sign-in reached a desktop in 37 s, then ran the CPU at 30–100% for 3½–7½ minutes (OneDriveSetup, MsMpEng, SearchIndexer). Every run fromcleanpaid that again.The change
tofu/modules/guest: a newvgainput, null by default (the block is left out, so no other guest's plan changes), validated tostd,virtioorqxl.tofu/guests.tf:dot-windowssetsvga = "virtio". Theviogpudodriver was already in 911's driver store, so the clone needs nothing more.test-the-dotfiles-layers.md§3: after the prerequisite bake, signtesterin once through a one-shot autologon, wait until the guest is idle, sign out, and remove the autologon (AutoAdminLogon=0, noDefaultPassword). §3 also notes the display. There's an as-run row and a changelog entry.Applied and verified on 198
0 to add, 1 to change:dot-windowsin place,+ vga { type = "virtio" }. Applied targeted, andqm configshowsvga: memory=16,type=virtio.cleanwas retaken while stopped.clean: the desktop appears in 36 s and the guest settles in about 2 minutes, down from 3½–7½. Rolled back tocleanafterwards.This PR is based on #1111's branch, because it extends the bake section #1111 adds. Merge #1111 first; after that, this diff is only the display and sign-in changes. markdownlint-cli2,
check_docs.py,tofu fmt -checkandtofu validateare clean.🤖 Generated with Claude Code