Repository navigation
fix(secrets): odin's ingest token, which the soc stack requires, is in git - #1046
Merged
Merged
Conversation
…n git
stacks/soc/compose.yaml requires INGEST_TOKEN (${INGEST_TOKEN:?}), but
secrets/soc.sops.yaml on main never had it: the key was added on odin
on 2026-10-04 at 13:09 UTC, during #834's per-client ingest tokens, and
stayed an uncommitted edit there. odin ran on that copy; a fresh
checkout would fail make up.
This is odin's file byte for byte (sha256 068c3794...). It adds one key;
every other value is unchanged, and the recipient is the same one age
key. It decrypts on odin with a valid MAC, and alexander's ingest proxy
has rejected nothing from odin.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🔵 Needs a closer look
The encrypted token’s value and correspondence with the proxy token cannot be independently verified from the diff.
0 open findings
What changed in this PR
Adds Odin’s encrypted ingest token required by the SOC stack.
Changes:
- Adds
INGEST_TOKEN. - Updates SOPS metadata and MAC.
| File | Description |
|---|---|
secrets/soc.sops.yaml |
Stores Odin’s encrypted lab ingest token. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Owner
Author
|
On the review's point that the diff can't show this token matches the proxy's, I checked it without printing either value. Each side's decrypted value was hashed with sha256; the first 16 hex digits:
They are the same token. No code change needed. 🤖 Addressed by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This commits odin's
secrets/soc.sops.yamlas it stands onodin. It adds one key,INGEST_TOKEN: the tokenodin's Alloy sends toalexander's ingest proxy. Its lab-side copy isINGEST_TOKEN_ODINinsecrets/lab.sops.yaml.Why
stacks/soc/compose.yamlrequires this key (INGEST_TOKEN: ${INGEST_TOKEN:?set in secrets/soc.sops.yaml}), but the file onmainnever had it. On a fresh checkout, a rebuiltodinwould failmake up.odinon 2026-10-04 at 13:09:35 UTC, going by the file's own sopslastmodified. That was during The lab Prometheus and Loki take unauthenticated writes, /-/quit and log deletion from the whole of VLAN 30 #834's per-client ingest tokens, between feat(sensor): fenrir's own age key and its ingest token (#834) #905 (fenrir's token) and feat(lab): the four ingest tokens the proxy checks (#834) #907 (the four tokens the proxy checks). It stayed an uncommitted edit inodin's checkout, carried across pulls by autostash.fenrirandedenalready have theirs in git:sensor.sops.yamlandbloodhound.sops.yamleach carry anINGEST_TOKEN.Checks
odin's: sha256068c37943918e9199f30d5292f39b01feba9a7ab24615079cc71b04fb13ba0fbon both.lastmodifiedandmac. Every other value is unchanged, and the recipient is the same single age key.odinwith a valid MAC. It was decrypted to/dev/null; no value was printed.alexander's ingest proxy rejected nothing from10.0.30.60.check-sops-encrypted.shandcheck_sops_rules.pypass.After merge
odin's working copy will be identical tomain, so the nextgit pullthere leaves nothing to stash.🤖 Generated with Claude Code