Skip to content

Fail a PR whose close keywords sit in prose that says the issue stays open #672

Closed

Description

@Gerrrt

Close keywords in prose have shut eight issues by accident

GitHub reads close/closes/fix/fixed/resolve followed by #N anywhere in a PR body or commit message, including inside a sentence that says the opposite, after a colon, or across a line break. This repo uses Refs #N on purpose for work that closes on a physical act or a deploy. Its prose keeps tripping the matcher anyway:

Issue Closed by The phrase
#182 #319 "would close #182 by accident"
#251 #252 "filed rather than fixed: #251"
#359 #382 "Partly closes #359"
#418 #521 "the measurement is what closes #418"
#531 #545 "What closes #531 is still the fit"
#571 #652 "Closes nothing yet… closes #571 with #558"
#92 #664 "closes: #92 closes when the rehearsal runs"
#523, #573, #611 closed and reopened within minutes

#182, #251 and #571 sat closed for days to weeks with the work undone and no tracker. They were found only by a full pass on 2026-09-26.

Checking by hand after opening a PR (closingIssuesReferences) is the current mitigation, and it has not been enough.

What to build

A PR check that reads closingIssuesReferences over GraphQL and fails when any linked issue is also named with Refs in the same body, or appears in a sentence containing not, nothing or stays open. At minimum it should write the list of issues the merge will close into the job summary, so it is visible before merge. A commit-message scan for the same patterns catches squash bodies.

Refs #670.

Activity

  1. added this to the Nothing blocks these milestone on Sep 26, 2026
  2. added
    featureA new capability or a change
    ciGitHub Actions workflows
    on Sep 26, 2026
  3. added 2 commits that reference this issue on Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ciGitHub Actions workflowsfeatureA new capability or a change

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions