Skip to content

Home Assistant: delete ring_push_guard's firebase_messaging patch once firebase-messaging ships the header fix (ADR-0110) #1383

Open

Description

@Gerrrt

ADR-0110 adds a second patch to ring_push_guard, for firebase_messaging 0.4.5, the push client underneath ring_doorbell. It reads the crypto-key and encryption headers by position ([3:], [5:]). Some Ring pushes now carry dh=<key>; p256ecdsa=<key>, so decoding fails with binascii.Error: Incorrect padding. The client then shuts down for good, and because the push is never acknowledged, FCM sends it again on every reconnect (sdb9696/firebase-messaging#44). ADR-0101's parser patch never sees it.

On trinity, the Ring event.* entities recorded no real event in the recorder's ten days (since 2026-10-31). The log on 2026-11-10 at 00:30 UTC has Unknown error: Incorrect padding, shutting down FcmPushClient.

The patch picks dh and salt by name and restores their padding, as upstream PR sdb9696/firebase-messaging#43 does. A push it still cannot decrypt is logged as Dropped a push it could not decrypt and acknowledged, instead of stopping the client. It applies only to 0.4.5 and warns on any other version.

Activity

  1. added
    featureA new capability or a change
    sensitivestacks/sensitive on trinity (VLAN 99)
    on Nov 10, 2026
  2. added this to the Nothing blocks these milestone on Nov 10, 2026
  3. changed the title [-]Home Assistant: delete ring_push_guard's firebase_messaging patch once firebase-messaging ships the header fix (ADR-0109)[/-] [+]Home Assistant: delete ring_push_guard's firebase_messaging patch once firebase-messaging ships the header fix (ADR-0110) [/+] on Nov 10, 2026
  4. changed the title [-]Home Assistant: delete ring_push_guard's firebase_messaging patch once firebase-messaging ships the header fix (ADR-0110) [/-] [+]Home Assistant: delete ring_push_guard's firebase_messaging patch once firebase-messaging ships the header fix (ADR-0110)[/+] on Nov 10, 2026
  5. Gerrrt commented on Nov 11, 2026

    @Gerrrt
    OwnerAuthor

    Deployed and checked on trinity.

    • PR fix(sensitive): keep Ring's push client alive on two-part Web Push headers (ADR-0110) #1386 merged on 2026-11-10 at 14:58 UTC. Home Assistant had been running since 04:31 that day, so it never loaded fcm_patch.py, and the client crashed again at 07:37 (Incorrect padding, shutting down FcmPushClient).
    • Home Assistant restarted on 2026-11-11 at 02:49 and again at 02:50 UTC. The Home Assistant: delete ring_push_guard once ring_doorbell ships the ding.id fix (ADR-0101) #1240 session and the user each restarted it, without knowing about the other. Both runs loaded the patch. There was no version warning: firebase-messaging is 0.4.5.
    • Real Ring events reached the recorder again: event.patio_patio_motion at 02:52:52, 02:52:58, 02:54:08 and 02:54:12 UTC. Before this, the newest real Ring event was from 2026-10-28.
    • Home Assistant moved to 2026.11.1 at 04:31 UTC. It still ships firebase-messaging 0.4.5 and ring-doorbell 0.9.14, and the patch loaded again with no warning.
    • Neither log since the 02:50 restart has Incorrect padding, shutting down FcmPushClient or Dropped a push.

    So the push client now survives the two-part headers and events flow. The first box is ticked.

    The issue stays open for the other two boxes. sdb9696/firebase-messaging #43 and #46 are still unmerged, and 0.4.5 is still the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    featureA new capability or a changesensitivestacks/sensitive on trinity (VLAN 99)

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions