You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Home Assistant: delete ring_push_guard's firebase_messaging patch once firebase-messaging ships the header fix (ADR-0110) #1383
ADR-0110 adds a second patch to ring_push_guard, for firebase_messaging 0.4.5, the push client underneath ring_doorbell. It reads the crypto-key and encryption headers by position ([3:], [5:]). Some Ring pushes now carry dh=<key>; p256ecdsa=<key>, so decoding fails with binascii.Error: Incorrect padding. The client then shuts down for good, and because the push is never acknowledged, FCM sends it again on every reconnect (sdb9696/firebase-messaging#44). ADR-0101's parser patch never sees it.
On trinity, the Ring event.* entities recorded no real event in the recorder's ten days (since 2026-10-31). The log on 2026-11-10 at 00:30 UTC has Unknown error: Incorrect padding, shutting down FcmPushClient.
The patch picks dh and salt by name and restores their padding, as upstream PR sdb9696/firebase-messaging#43 does. A push it still cannot decrypt is logged as Dropped a push it could not decrypt and acknowledged, instead of stopping the client. It applies only to 0.4.5 and warns on any other version.
Deploy and confirm: no Incorrect padding or shutting down FcmPushClient in the log, and Ring event.* states change on real motion through a day
changed the title [-]Home Assistant: delete ring_push_guard's firebase_messaging patch once firebase-messaging ships the header fix (ADR-0109)[/-][+]Home Assistant: delete ring_push_guard's firebase_messaging patch once firebase-messaging ships the header fix (ADR-0110)
[/+]on Nov 10, 2026
changed the title [-]Home Assistant: delete ring_push_guard's firebase_messaging patch once firebase-messaging ships the header fix (ADR-0110)
[/-][+]Home Assistant: delete ring_push_guard's firebase_messaging patch once firebase-messaging ships the header fix (ADR-0110)[/+]on Nov 10, 2026
Real Ring events reached the recorder again: event.patio_patio_motion at 02:52:52, 02:52:58, 02:54:08 and 02:54:12 UTC. Before this, the newest real Ring event was from 2026-10-28.
Home Assistant moved to 2026.11.1 at 04:31 UTC. It still ships firebase-messaging 0.4.5 and ring-doorbell 0.9.14, and the patch loaded again with no warning.
Neither log since the 02:50 restart has Incorrect padding, shutting down FcmPushClient or Dropped a push.
So the push client now survives the two-part headers and events flow. The first box is ticked.
The issue stays open for the other two boxes. sdb9696/firebase-messaging #43 and #46 are still unmerged, and 0.4.5 is still the latest release.
Activity
fix(sensitive): keep Ring's push client alive on two-part Web Push he…
fix(sensitive): log only allowlisted Web Push parameter names in ring…
Merge origin/main into gerrrt/ring-fcm-guard; renumber the ADR to 0110
[-]Home Assistant: delete ring_push_guard's firebase_messaging patch once firebase-messaging ships the header fix (ADR-0109)[/-][+]Home Assistant: delete ring_push_guard's firebase_messaging patch once firebase-messaging ships the header fix (ADR-0110) [/+][-]Home Assistant: delete ring_push_guard's firebase_messaging patch once firebase-messaging ships the header fix (ADR-0110) [/-][+]Home Assistant: delete ring_push_guard's firebase_messaging patch once firebase-messaging ships the header fix (ADR-0110)[/+]fix(sensitive): keep Ring's push client alive on two-part Web Push he…
Gerrrt commentedon Nov 11, 2026
Deployed and checked on
trinity.fcm_patch.py, and the client crashed again at 07:37 (Incorrect padding, shutting down FcmPushClient).firebase-messagingis 0.4.5.event.patio_patio_motionat 02:52:52, 02:52:58, 02:54:08 and 02:54:12 UTC. Before this, the newest real Ring event was from 2026-10-28.firebase-messaging0.4.5 andring-doorbell0.9.14, and the patch loaded again with no warning.Incorrect padding,shutting down FcmPushClientorDropped a push.So the push client now survives the two-part headers and events flow. The first box is ticked.
The issue stays open for the other two boxes. sdb9696/firebase-messaging #43 and #46 are still unmerged, and 0.4.5 is still the latest release.