Skip to content

[Fixes #14701] Thesaurus keyword autocomplete does not work - #14703

Merged
etj merged 2 commits into
masterfrom
14701_tkeyword
Oct 7, 2026
Merged

etj merged 2 commits into
masterfrom
14701_tkeyword

Conversation

@etj

@etj etj commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #14701

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@etj etj self-assigned this Oct 6, 2026
Copilot AI balanced review requested due to automatic review settings October 6, 2026 15:58
@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Oct 6, 2026
@etj
etj requested a review from giohappy October 6, 2026 15:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Multiple matching translations inflate resource counts and can alter result ordering.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Addresses #14701 by correcting localized-label lookup for thesaurus keyword autocomplete in catalog filters.

Changes:

  • Searches related keyword labels.
  • Adds regression tests for matching and nonmatching searches.
File Description
geonode/​facets/​tests.py Tests keyword filtering results.
geonode/​facets/​providers/​thesaurus.py Corrects the label lookup path.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread geonode/facets/providers/thesaurus.py Outdated
@etj
etj merged commit 0d7e6e2 into master Oct 7, 2026
15 checks passed
@etj
etj deleted the 14701_tkeyword branch October 7, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Thesaurus keyword autocomplete does not work

3 participants