Skip to content

Refactor train CLI into core, with CLI and API shims - #893

Open
joanise wants to merge 5 commits into
dev.ej/fs2-prepro-v2from
dev.ej/refactor-train
Open

joanise wants to merge 5 commits into
dev.ej/fs2-prepro-v2from
dev.ej/refactor-train

Conversation

@joanise

@joanise joanise commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

PR Goal?

Next stage in my CLI/API refactoring stack: refactor all the train() functions.

Feedback sought?

careful review

Priority?

low until the whole stack is ready

Tests added?

For the CLI, I retroactively added #892 and adjusted it for this PR.

For the API, not yet, that'll come later in the stack.

How to test?

run various train commands and see they work the same as before

Confidence?

high

Version change?

yes, along with the whole stack

Related PRs?

Builds on top of #885

EveryVoiceTTS/FastSpeech2_lightning#169
EveryVoiceTTS/HiFiGAN_iSTFT_lightning#70
EveryVoiceTTS/StyleTTS2#39

@joanise
joanise added this pull request to stack #886 September 23, 2026 21:03
@semanticdiff-com

semanticdiff-com Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Review changes with  SemanticDiff

Changed Files
File Status
  everyvoice/base_cli/helpers.py  12% smaller
  everyvoice/api/__init__.py  0% smaller
  everyvoice/api/fs2.py  0% smaller
  everyvoice/api/hfgl.py  0% smaller
  everyvoice/api/styletts2.py  0% smaller
  everyvoice/model/e2e/StyleTTS2_lightning  0% smaller
  everyvoice/model/feature_prediction/FastSpeech2_lightning  0% smaller
  everyvoice/model/vocoder/HiFiGAN_iSTFT_lightning  0% smaller
  everyvoice/tests/data/all_help.txt Unsupported file format

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor
CLI load time: 0:00.27
Pull Request HEAD: d4b84767bb7e41e02219f9c0518ca7498f0e851d

Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:    124813 |     125493 |         difflib
import time:      7027 |     133441 |       typer.core
import time:      7868 |     160820 |     typer.main
import time:      1429 |     198715 |   typer
import time:    134280 |     134280 |   merge_args
import time:      5248 |     114601 |       rich.markdown
import time:      4315 |     205503 |     typer.rich_utils
import time:       608 |     206110 |   everyvoice.base_cli
import time:       427 |     189171 |         everyvoice.model.feature_prediction.FastSpeech2_lightning.fs2.cli.cli
import time:       378 |     190603 |       everyvoice.model.feature_prediction.FastSpeech2_lightning.fs2.cli
import time:      1362 |     191964 |     everyvoice.model.feature_prediction.FastSpeech2_lightning.fs2.cli.check_data
import time:      2476 |     197778 |   everyvoice.base_cli.check_group
import time:      7668 |     893393 | everyvoice.cli

@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.11%. Comparing base (4c3b1e5) to head (d4b8476).

Files with missing lines Patch % Lines
everyvoice/api/fs2.py 0.00% 2 Missing ⚠️
everyvoice/api/hfgl.py 0.00% 2 Missing ⚠️
everyvoice/api/styletts2.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           dev.ej/fs2-prepro-v2     #893      +/-   ##
========================================================
- Coverage                 85.20%   85.11%   -0.09%     
========================================================
  Files                        51       54       +3     
  Lines                      4799     4804       +5     
  Branches                    716      716              
========================================================
  Hits                       4089     4089              
- Misses                      536      541       +5     
  Partials                    174      174              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joanise
joanise force-pushed the dev.ej/refactor-train branch from 46845e5 to df77d46 Compare September 24, 2026 21:04
@joanise
joanise force-pushed the dev.ej/refactor-train branch from 5484f56 to a54d16c Compare October 28, 2026 19:07
@joanise
joanise force-pushed the dev.ej/refactor-train branch 2 times, most recently from a4dd1fd to 4162196 Compare November 4, 2026 21:41
@joanise
joanise force-pushed the dev.ej/refactor-train branch from 4162196 to d4b8476 Compare November 6, 2026 20:45

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant