Repository navigation
Conversation
Changed Files
|
Contributor
|
This was referenced Sep 23, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev.ej/fs2-prepro-v2 #893 +/- ##
========================================================
- Coverage 85.20% 85.11% -0.09%
========================================================
Files 51 54 +3
Lines 4799 4804 +5
Branches 716 716
========================================================
Hits 4089 4089
- Misses 536 541 +5
Partials 174 174 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
joanise
force-pushed
the
dev.ej/refactor-train
branch
from
September 24, 2026 21:04
46845e5 to
df77d46
Compare
joanise
force-pushed
the
dev.ej/refactor-train
branch
from
October 28, 2026 19:07
5484f56 to
a54d16c
Compare
joanise
force-pushed
the
dev.ej/refactor-train
branch
2 times, most recently
from
November 4, 2026 21:41
a4dd1fd to
4162196
Compare
joanise
force-pushed
the
dev.ej/refactor-train
branch
from
November 6, 2026 20:45
4162196 to
d4b8476
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
Next stage in my CLI/API refactoring stack: refactor all the train() functions.
Feedback sought?
careful review
Priority?
low until the whole stack is ready
Tests added?
For the CLI, I retroactively added #892 and adjusted it for this PR.
For the API, not yet, that'll come later in the stack.
How to test?
run various train commands and see they work the same as before
Confidence?
high
Version change?
yes, along with the whole stack
Related PRs?
Builds on top of #885
EveryVoiceTTS/FastSpeech2_lightning#169
EveryVoiceTTS/HiFiGAN_iSTFT_lightning#70
EveryVoiceTTS/StyleTTS2#39