Repository navigation
ctsm5.4.068: Move CTSM tests from gx grids to t233 grid - #4234
slevis-lmwg wants to merge 39 commits into
Conversation
|
I'd call this as something that should go on master, because when compsets change you can't verify that things are b4b. And hence it could hide an accidental non-b4b change on the b4b-dev branch after this was merged. |
ekluzek
left a comment
There was a problem hiding this comment.
We went over this together. And I noted the thing about g37 grids should be t201 as the low resolution MOM grid. And we realized that MOSART and RTM (and ccs_config) also need to be updated similarly.
|
Marking "blocked" due to the checkbox above stating that we need to "add to ccs_config: ne30_t233, f19_t233_gris4 and make new tag" |
ctsm5.4.063: Move CTSM tests from t232 to t233 Updating testlist_clm.xml, ExpectedTestFails.xml, config_compsets.xml, and documentation that needs updating. NB: Moving tests from t232 to t233 but postpone the change for LII2 tests (issue ESCOMP#4245). Changes answers relative to the baseline, only for cases with grids that changed to the t233 grid, and only due to the grid update. PR ESCOMP#4223 Resolves issue ESCOMP#4238 by removing NorESM test Contributes to ESCOMP#2540 Move testing from POP to MOM masks slevis resolved conflicts: cime_config/testdefs/testlist_clm.xml
|
Since updating submodules... Consider updating CIME for #4239 here? From meeting with Erik: No, because this PR here is effectively an answer-changing PR. |
|
|
Sorry that I didn't see the question about the LVG test earlier. I do not expect changing finidat to resolve this. I checked the test failure, and I see that the only field that differs is PCT_GLC_MEC. I think the right thing to do is to simply exclude this history field from the test, using hist_fexcl. You can do this via I think I understand why this is needed: There is a grid cell on the south tip of South America that has 0% glacier which must newly be present within the land mask (I haven't looked at the change in land mask, but I assume that's why it's a problem now). In the base case, this has 0% for each glacier column, but in the case with extra virtual glacier, it must fall within the Antarctica mask, and so it is given non-zero percentages in each column. This is a fine difference and should just be ignored. |
Fix scheduled docs-update-ctsm_pylib workflow slevis resolved conflicts: cime_config/testdefs/testlist_clm.xml doc/ChangeLog doc/ChangeSum
|
In prep for the merge
My comment from last time sounded as though I had resolved the LII2 test failures, but it seems I forgot to update their grids in testlist_clm.xml, so doing now.
|
slevis resolved conflicts: doc/ChangeLog doc/ChangeSum
|
Most recent testing discussed in the ccs_config PR. Erik and I agreed to remove a failing test as irrelevant because it turns on matrixcn in an IHist compset. |
|
|
@ekluzek I will rerun aux_clm now that I have fully updated ccs_config. I expect the same results that I got when I ran aux_clm from ESMCI/ccs_config_cesm#313.
Could you do a final review of this PR? |
|
@ekluzek testing was good, so I'm ready. |
| @@ -2604,7 +2592,7 @@ | |||
| <option name="comment">Repeat LII_D... test with matrixcnOn</option> | |||
| </options> | |||
| </test> | |||
| <test name="LII2FINIDATAREAS_D_P256x2_Ld1" grid="f09_t232" compset="I1850Clm60BgcCrop" testmods="clm/default"> | |||
| <test name="LII2FINIDATAREAS_D_P256x2_Ld1" grid="f09_t233" compset="I1850Clm60BgcCrop" testmods="clm/default"> | |||
There was a problem hiding this comment.
Both LII2 tests need to go back to t232 as part of reverting namelist_defaults as per Erik's review.
Description of changes
Similar to #4223 but for g16, g17, g37 grids
history_tape_in_usefunctionality RTM#62 <-- not doneSpecific notes
Contributors other than yourself, if any: @ekluzek
CTSM issues resolved or otherwise addressed, if any:
Contributes to #2540 (resolves?)
Testing planned or performed, if any:
aux_clm and others, see below
Erik, editing to say we should run most test lists as almost all tests change:
Requirements before merge: