Skip to content

Set canonical-example source and numeric-bin policy - #591

Merged
realmarcin merged 1 commit into
mainfrom
fix/canonical-example-policy-475-478
Aug 30, 2026
Merged

realmarcin merged 1 commit into
mainfrom
fix/canonical-example-policy-475-478

Conversation

@realmarcin

@realmarcin realmarcin commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

Closes #475.
Closes #478.

Unblocks the quantitative and morphometric portion of #444. The live ADD_CANONICAL_EXAMPLES queue is 89 records.

Policy

  • canonical_examples[].reference is the provenance for the trait-to-taxon claim; a mechanism report is a lead, not an own-artifact requirement
  • morphometric/quantitative examples require an unperturbed natural organism and a direct measurement with value, units, strain, and relevant conditions
  • prefer primary measurement/species-description sources; use BacDive-like databases for discovery and cite their underlying source when available
  • do not use paid mechanism research to fill canonical examples; skip when open evidence is inadequate
  • put a measured claim on the narrowest bin containing its complete interval; cross-parent/sibling discovery is allowed; do not duplicate the same claim on parent and bin

Applied correction

Moves Wallemia ichthyophaga from NaCl optimum to NaCl optimum high: the cited 15-20% (w/v) optimum is wholly above the bin's >8% threshold. The validated dry-run migration records per-trait curation events and append-only repository history; pages and the graph protein/taxon report are regenerated.

Verification

  • uv run pytest -q (877 passed)
  • just qc
  • just validate-history (64 records, 0 invalid)
  • just audit-canonical-examples --ncbi-api (436 resolved, 0 errors, 24 pre-existing label warnings)
  • non-generated diff check passed; generated HTML retains template whitespace

@realmarcin
realmarcin merged commit 6de50a1 into main Aug 30, 2026
10 checks passed
@realmarcin
realmarcin deleted the fix/canonical-example-policy-475-478 branch August 30, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant