Repository navigation
Backfill canonical_examples batch 1: 5 records filled, 6 honest skips (#444) - #474
Merged
Merged
Conversation
…#444) First batch after the #446 canary, run by its rules: exemplars come only from each trait's own deep-research artifact, every taxon id resolved and label-checked against the local NCBITaxon build, contrast cases excluded by name with the artifact's own disqualifying language recorded in each record's curation_history, and a record whose artifact establishes no instance is SKIPPED rather than approximately filled. Targets from the #449 priority dashboard's ADD_CANONICAL_EXAMPLES queue, top first. FILLED (8 examples): stenohaline (Synechococcus sp. YX04-3, grew at 32 ppt and could not survive 13 ppt while euryhaline HK05 grew at both); temperature_delta_high (Exiguobacterium chiriqhucha, strain RW2 grown 4-50 C, a 46 C breadth); nacl_delta_high (Aspergillus sydowii, 0 to saturated 5.13 M NaCl; Wallemia ichthyophaga, 10-32% w/v); nacl_optimum (W. ichthyophaga, kinetically determined 15-20% optimum); temperature_optimum_high (Saccharolobus islandicus 76 C, Pyrococcus furiosus 90 C, Thermococcus kodakarensis 85 C at mu=0.69/h). SKIPPED (6): temperature_delta_very_low, ph_delta_mid2, ph_delta_mid3, ph_delta_very_low, ph_range_mid2, cell_length_large -- each because the trait's own artifact establishes no organism as an instance, most saying so explicitly. The strongest cross-check: E. chiriqhucha's 4-50 C measurement is simultaneously the exemplar for temperature_delta_high and the negative evidence for temperature_delta_very_low. 323 examples across 231 records, 0 errors, 1 pre-existing warning (heterocyst label drift, #445); all 7 new taxon ids independently re-verified; corpus re-emitted through write_validated_trait so the round-trip invariant holds; pages regenerated; 677 tests, qc green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
Adversarial review done as a separate pass:
Awaiting your go-ahead to merge. |
This was referenced Aug 20, 2026
…s, normalize placement (#476, #477) An independent adversarial content review of this PR (findings filed as #476-#478) found that two of temperature_optimum_high's three draft exemplars asserted optima their artifact never states: P. furiosus's 90 C is the study's CONTROL condition against 98 C "supra-optimal" stress, and T. kodakarensis's 75-93 C series endpoints are delta-rgy mutant data with one wild-type point at 85 C. Both removed; S. islandicus (76 C, the one explicitly stated optimum) stays. The batch is now 5 records, 6 examples. Also from that review: the A. sydowii note no longer claims the multi-omics study establishes growth at "both ends" of the 0-to-saturation interval (it compared 1 M and saturated; even that spans ~24 points w/v, still far past the ~8% bin); the stenohaline note now carries the artifact's own "complete tolerated interval remains unknown"; three curation_history quotes are restored to their conditional originals (Shewanella "without additional endpoint data", "avoiding unjustified conversion", Halomonas back in the MAG list); and canonical_examples now sits after `evidence` in all five records PLUS the #446 canary, matching the 225-record corpus norm instead of the canary's end-of-file deviation (#477). #478 (bin-measured exemplars landing on family parents) is filed as a policy decision, not changed here. Removing the two entries also removed the PR's only two uppercase DOIs. 321 examples across 231 records, 0 errors, 1 pre-existing warning; round trip, pages, 677 tests, qc all green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
Second, independent adversarial review round complete (findings filed as #476–#478; fixed in f098513):
Reference provenance and taxon-label checks all cleared in this round too. 321 examples across 231 records, 0 errors; 677 tests, qc green; CI green on the head commit. |
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First
canonical_examplesbatch after the #446 canary, addressing the ~130-record gap tracked in #444. Batch size: 11 records, taken from the top of the #449 priority dashboard'sADD_CANONICAL_EXAMPLESqueue. Two adversarial review rounds ran on this PR; the second (independent) round removed two draft exemplars and is documented in #476–#478.Rules (the canary's, applied unchanged)
curation_historyentry.Filled — 5 records, 6 examples
environment/stenohalineenvironment/temperature_delta_highenvironment/nacl_delta_highenvironment/nacl_optimumenvironment/temperature_optimum_highSkipped — 6 records, each with the artifact's own words
temperature_delta_very_low,ph_delta_mid2,ph_delta_mid3,ph_delta_very_low,ph_range_mid2,cell_length_large. Every candidate organism in those artifacts is a mechanism host, a one-sided measurement, or an explicit contrast case; several artifacts state the negative result outright. Best cross-check in the batch: E. chiriqhucha's single 4–50 °C measurement is simultaneously the exemplar fortemperature_delta_highand the negative evidence fortemperature_delta_very_low.The
cell_length_largeskip generalizes: cell-size bins need a taxon-oriented source (#475).Review trail
Round 1: reference DOIs mechanically verified present in each trait's own artifact; all taxon ids re-resolved. Round 2 (independent reviewer): #476 (two unestablished optima — removed), #477 (EOF placement vs corpus norm — normalized, canary included), #478 (bin-measured exemplar on a family parent — open policy question), plus five wording drifts fixed.
Verification
just audit-canonical-examples: 321 examples across 231 records, 0 errors, 1 pre-existing warning (heterocyst label drift, audit-canonical-examples exists (#446) but is not wired into qc or any workflow #445).write_validated_trait; byte-canonical round-trip holds.validate-strict, fullqc, and 677 tests green.history/other/canonical-examples-batch1/.🤖 Generated with Claude Code