Repository navigation
Add literature-backed SduA protein example to Shedu system - #1802
Merged
Merged
Conversation
Adds a GENE_OR_PROTEIN causal node for the single-protein Shedu immune nuclease on traitmech:000220 (Shedu system) and attaches UniProtKB:B7HFR2 (Shedu protein SduA, Bacillus cereus B4264, NCBITaxon:405532) as a taxon-paired protein example with primary literature evidence from Gu et al. 2024 Mol Cell (PMID:39742666, DOI:10.1016/j.molcel.2024.12.004), whose cryo-EM entries 8TI8/8TI9/8TIA PDBe maps to that exact accession. The node is REVIEWED_LABEL_ONLY: InterPro has only domain-level SduA entries (IPR025359, Pfam PF14082 SduA_C, formerly DUF4263, and IPR048396, Pfam PF21407 SduA_N), so grounding a whole-protein node to one of its domains would be the domain trap docs/GROUNDING_POLICY.md forbids. The Cap4 (UniProtKB:C0VHC9) and DruA (UniProtKB:P0DW34) candidates were not added; the pull request records why. Written through scripts/add_shedu_sdua_protein_example.py (--apply opt-in, record_curation_event, write_validated_trait) with an append-only history record and regenerated derived reports and pages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
realmarcin
force-pushed
the
duf-protein-examples
branch
from
October 8, 2026 03:34
ed0caa0 to
5d6cd39
Compare
This was referenced Oct 8, 2026
Review finding: SduA protein-example role asserted a domain class its evidence did not support
#1804
Closed
Closed
Protein-example leads: Cap4 (C0VHC9) and DruA (P0DW34) blocked on non-open-access primary text
#1807
Open
Addresses #1808, #1809, #1810, #1811, #1812 and #1813 on the Shedu SduA protein example added in #1802. #1808 Regenerated reports/uniprot_grounding_audit.tsv with the live UniProt REST API (anonymous, no address in any request). Exactly three rows change: B7HFR2 added clean, P06115 added clean, and the stale HTTP 503 row for A0A0F6B2U2 now resolves clean. Findings drop 111 -> 110, the remainder being the pre-existing entry-version drift in #1806, which is why the recipe still exits 1 while writing a current report. #1809 The SduA -> shedu_nuclease_activation edge description no longer generalizes a B. cereus finding across Shedu homologs; it names the organism and says why, since the graph's scope_notes leave the sensor class open and the Loeff edge gives the N-terminal domain a different role in another homolog. Snippet reuse in the graph stays at 2. #1810 The label-only justification no longer claims the grounding policy forbids a domain grounding. It states what is true: no family-level InterPro, NCBIfam or GO term covers SduA, only the domain entries IPR025359 and IPR048396 exist, and PF14082 spans 1304 UniProt proteins across 2464 taxa with 18 domain architectures, so a domain term would not denote this protein family. #1811 The curation event carries the real UTC time of the change rather than a midnight placeholder. retrieved_on and the bounded-search date move to the same UTC day. Because pages derive their "Corpus as of" stamp from the newest curation_history entry, that moves every page's stamp; the pages are regenerated, not edited. #1812 The role field quotes the source's "controlled by" rather than the stronger "switched by", and attributes the single-component architecture to UniProt, which is where it comes from. #1813 The history record gains links.prs (#1802) and links.issues (#1807) and no longer points at the PR body for facts that belong in the record. Rebuilt through scripts/add_shedu_sdua_protein_example.py --apply from the origin/main base, then regenerated pages and derived reports. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # pages/browse.html # pages/category/ecology.html # pages/category/environment.html # pages/category/genomics.html # pages/category/metabolism.html # pages/category/morphology.html # pages/category/observation.html # pages/category/other.html # pages/category/physiology.html # pages/category/quantitative_property.html # pages/category/upper.html # pages/graph.html # pages/umap.html
Adds tests/test_add_shedu_sdua_protein_example.py in the style of the writer tests #1801 and #1803 shipped: the writer is pointed at a temp copy via monkeypatched TARGET/REPO_ROOT, driven through main() with and without --apply, and judged by before/after snapshots of the temp tree. The writer edits an existing record, so the base it is applied to is derived from the committed record by removing exactly the node, edge and curation event it adds, each asserted to occur once. That derived base was checked to equal the origin/main record. Covered: - dry run is the default and writes nothing, here or in the repo; - applying to the base emits exactly the committed node (B7HFR2, NCBITaxon:405532, REVIEWED, entry v58 / seq v1, label-only grounding), the committed edge, and one curation event with the writer's timestamp, and changes nothing else in the record; - refusal when sdua_immune_nuclease already exists, both after a first apply and on the committed record itself; - refusal for a different identifier and unless exactly one shedu_dna_end_nicking graph exists, and when the edge's object node is missing; - a closed-schema validation failure writes nothing. An autouse fixture makes any socket connection fail the test, so the suite cannot reach UniProt or Europe PMC. Mutating the writer's entry version or timestamp makes the round-trip test fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # pages/browse.html # pages/category/ecology.html # pages/category/environment.html # pages/category/genomics.html # pages/category/metabolism.html # pages/category/morphology.html # pages/category/observation.html # pages/category/other.html # pages/category/physiology.html # pages/category/quantitative_property.html # pages/category/upper.html # pages/graph.html # pages/umap.html
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1804, fixes #1805, fixes #1808, fixes #1809, fixes #1810, fixes #1811, fixes #1812, fixes #1813, fixes #1818.
What this adds
One protein example, on one record.
data/traits/genomics/shedu_system.yaml(traitmech:000220) gains aGENE_OR_PROTEINcausal node,sdua_immune_nuclease, carryingUniProtKB:B7HFR2(Shedu protein SduA, Bacillus cereus B4264,NCBITaxon:405532) as a taxon-pairedprotein_examplesentry, plus onecontributes to(RO:0002326) edge into the existingshedu_nuclease_activationnode.mapping_statusstaysPROPOSED;scope_statusstaysNONMECHANISTIC; definition, hierarchy, synonyms,canonical example and existing evidence are untouched.
The node is
grounding_status: REVIEWED_LABEL_ONLYwith notes: InterPro hasonly domain-level entries for this single-protein system —
IPR025359(SduA C-terminal, Pfam
PF14082SduA_C, formerlyDUF4263) andIPR048396(SduA N-terminal, Pfam
PF21407) — and no GO, NCBIfam or Complex Portal termnames the protein family, so grounding the whole-protein node to one of its
domains would be the domain trap
docs/GROUNDING_POLICY.md§2 forbids.Evidence per protein
Added — SduA,
UniProtKB:B7HFR22026-10-08 UTC): current primary accession
B7HFR2, no secondaryaccessions,
reviewed(Swiss-Prot), entry nameSDUA_BACC4, protein name"Shedu protein SduA", gene
sduA, organism Bacillus cereus (strain B4264)= taxon
405532, entry version 58, sequence version 1. Pfamcross-references
PF14082(SduA_C, the formerDUF4263) andPF21407.just audit-uniprotresolves the new row with an empty finding (everycolumn
YES).DOI:10.1016/j.molcel.2024.12.004,PMID:39742666.cryo-EM entries
8TI8,8TI9and8TIAtoUniProtKB:B7HFR2(Bacillus cereus B4264), and the PDBe citation for
8TI8is that DOI/PMID.So the structurally characterised protein is this entry, not a same-species
homolog.
Europe PMC abstract of
PMID:39742666):between inactive and active states through conformational changes affecting
active-site architecture, which are controlled by the protein's N-terminal
domain (NTD)"
single protein of this Shedu system and carries the nuclease core whose
active site its own N-terminal domain switches between states. The paper's
survey of 79 N-terminal-domain types is about homologs and is not asserted of
this accession.
Skipped — Cap4,
UniProtKB:C0VHC9Two independent reasons, either of which is sufficient.
describes
C0VHC9as the effector DNase of a CBASS system: activated bya cyclic trinucleotide made by CdnD, its ligand binding in a C-terminal
SAVED domain, with the Lowey et al. 2020 PDB entries
6VM6/6WAMtitled"Acinetobacter baumannii Cap4 SAVED/CARF-domain containing receptor". That is
not
gao_her_duf_system.yaml/gao_her_system.yaml, which DefenseFindermodels as a two-profile
Gao_Her_DUF__DUF4297+Gao_Her_DUF__HerA_DUFlocus from Gao et al. 2020, and it is not
lamassu_cap4_nuclease_system.yaml, which is a Lamassu-Fam subtype with anSMC-like LmuB sensor and an LmuA effector — that record's own open discussion
already flags the relationship between the DefenseFinder
_IIrow andcharacterised Cap4 branches as unresolved. Shared Pfam membership
(
PF14130, formerlyDUF4297) is domain homology, not system identity, andthe repository's grounding policy is explicit that a family/domain match is
not an instance claim. The record whose biology does match is
cbass_system.yaml, which was not among the requested targets.source, Lowey et al. 2020 (
DOI:10.1016/j.cell.2020.05.019,PMID:32544385), is not open access: Europe PMC serves only the abstract,and that abstract names Enterobacter cloacae Cap4, not the Acinetobacter
protein. The only abstract-level sentences about
AbCap4are in a laterpaper (
PMID:36796558) restating Lowey et al., which is a secondarydescription rather than primary evidence for this protein's role.
Skipped — DruA,
UniProtKB:P0DW34UniProt verification passes (current reviewed primary accession,
DRUA_ECOU4,Escherichia coli UMEA 4076-1 = taxon
1281278, entry version 8, sequenceversion 1, Pfam
PF14236), but no primary snippet establishing DruA's ownrole is verifiable. Its only functional reference is Doron et al. 2018
(
DOI:10.1126/science.aar4120,PMID:29371424), which is not open access inEurope PMC; its abstract does not mention Druantia, DruA or UMEA 4076-1 at all.
A Europe PMC search for other Druantia primary work returns type-III/DruE
studies, nothing on DruA.
druantia_type_i_system.yamlalready records thesame limit from the other direction: Doron's type-I component is optional
("In some cases Type I systems are preceded by a gene annotated as DUF4338"),
the per-gene deletion set does not establish DruA dependence, and its open
discussion says no protein example is added without component-resolved
functional evidence. Adding
P0DW34would have been a UniProt record standingin for evidence, which the grounding policy forbids.
pd_t4_8_system.yamlwas not touched: PD-T4-8 is a separate DefenseFindersystem, not the SduA-centred Shedu record.
How it was written
scripts/add_shedu_sdua_protein_example.py— scoped to one target, assertstraitmech:000220and theshedu_dna_end_nickinggraph, dry-run by defaultwith
--applyopt-in, appends the per-record event throughrecord_curation_event(curator: claude,llm_assisted: true) and writesthrough
write_validated_trait. Append-only history record:history/records/shedu_system/2026-10-08T025652Z-claude-code-39f650.yaml.Derived artifacts were regenerated, never hand-edited:
reports/graph_protein_taxon_coverage.tsv,reports/node_grounding_residual.tsv,pages/traits/genomics/shedu_system.html.Gates run
just validate-strict data/traits/genomics/shedu_system.yamljust validate-history <new record>andjust validate-historyjust validate-productsjust audit-writersjust audit-graph-protein-taxa(--fail-on gaps)just audit-snippetsjust verify-snippets --record data/traits/genomics/shedu_system.yaml --fail-on paraphrasejust audit-uniprot(live)ENTRY_VERSION_MISMATCHrows tracked in #1806, but it writes a current report, which is why leaving the file atHEADwas wrongjust qcaudit-graphs,audit-predicate-domains,audit-derived-reports,audit-proposals, pages freshness)just gen-pagesaudit-derived-reportsreportsOK pages/git diff --checkAdversarial self-review (applied before review)
Reviewing the diff as a separate pass caught two overclaims, both fixed in this
branch rather than left in the record:
rolesaid SduA "carries the PD-(D/E)XK-type nuclease core".That domain naming comes from Loeff et al. on the E. coli KTE10 SduA, not
from the Gu et al. evidence attached here, so the role now says only what the
cited snippets support.
grounding_notesasserted a flat negative ("no GO, NCBIfam or Complex Portalterm names this protein family"). It now states the bounded search that was
actually run: an all-member-database InterPro search and an OLS4 GO search for
"Shedu" on 2026-10-08 UTC returned only
PF14082/PF21407and their InterProintegrations.
Two further facts were verified live rather than taken from the lead:
PF14082's former name: InterPro's name history for that Pfam entry isDUF4263thenSduA_C, so the "former DUF" premise holds for this family.NCBITaxon:405532resolves independently at NCBI Datasets to"Bacillus cereus B4264", rank STRAIN.
Open questions
cbass_system.yamlis left for a separatedecision: that record was not in scope here, and the snippet problem in
reason 2 above would still have to be solved, most likely from the paper's
full text rather than from Europe PMC.
audit-uniprot's 110 pre-existing entry-version mismatches are a corpus-widerefresh question, not something this change should silently absorb.
Second review round (#1808-#1813)
An independent review of the first commit found the PR sound and raised six
in-PR fixes, all applied in
86cff70c77:reports/uniprot_grounding_audit.tsvis regenerated from the liveUniProt REST API (anonymous) and committed. Exactly three rows change:
B7HFR2added clean,P06115added clean, and the staleHTTP 503row forA0A0F6B2U2now resolves clean (unreviewed, primary, taxon and bothversions matching). Findings go 111 -> 110; the remaining 110 are the
entry-version drift of audit-uniprot fails on 110 pre-existing ENTRY_VERSION_MISMATCH rows #1806. The first commit's reason for skipping the file
was wrong, and the gates table above is corrected.
across Shedu homologs: it names the organism and says why, since the graph's
scope_notesleave the sensor class open and the Loeff edge gives theN-terminal domain a DNA-end clamp role in a different homolog. Snippet reuse
in the graph stays at 2, the per-graph limit.
docs/GROUNDING_POLICY.mdforbids a domain grounding — it does not; it routesfamily/domain nodes to InterPro/Pfam and forbids generic UniProt groundings.
The note now states the actual reason: no family-level InterPro, NCBIfam or GO
term covers SduA, only
IPR025359/IPR048396exist, andPF14082spans1304 UniProt proteins across 2464 taxa with 18 domain architectures, so the
C-terminal domain term would sweep in carriers with different partner domains.
(
2026-10-08T04:22:03Z) instead of a midnight placeholder;retrieved_onandthe bounded-search date move to the same UTC day. Because
pages/derives its"Corpus as of" stamp from the newest
curation_historyentry (pages/ are stale and unverifiable: 119 differ from the data, and a build timestamp hides it #228), thatstamp moves on every page — regenerated via
just gen-pages, never edited,and
audit-derived-reportsreportsOK pages/.rolenow uses the source's "controlled by" rather than thestronger "switched by", and attributes the single-component architecture to
UniProt, which is where it comes from, since neither attached snippet says it.
links.prs(Add literature-backed SduA protein example to Shedu system #1802) andlinks.issues(Protein-example leads: Cap4 (C0VHC9) and DruA (P0DW34) blocked on non-open-access primary text #1807), and its
detailsno longer points at this PR body for facts thatbelong in the record.
The record was rebuilt from the
origin/mainbase throughscripts/add_shedu_sdua_protein_example.py --apply, so the committed YAML isstill exactly what the script produces. Every gate in the table above was re-run
after the fixes:
just qcexits 0,verify-snippetsreports 17/17 VERIFIED,audit-graph-protein-taxareports 0 gaps,audit-snippets0 new findings.Merge with
main#1801 and #1803 landed while this branch was open, which conflicted on 13
pages/files exactly asdocs/CURATION_PLAYBOOK.mdpredicts. Resolved byregeneration (
just gen-pagesplus every derived-report generator), not bypicking a side;
audit-derived-reportsthen reportsOK pages/and everyreport
OK (vs git). The merge isb2566d960e, and all eight CI checks pass onit.
Writer test (#1818)
tests/test_add_shedu_sdua_protein_example.pyfollows the writer tests #1801and #1803 shipped:
TARGETandREPO_ROOTare monkeypatched to a temp tree,main()is driven with and without--apply, and outcomes are judged bybefore/after snapshots. Because this writer edits an existing record, the base
is derived from the committed record by removing exactly the node, edge and
curation event it adds (each asserted to occur once); that derived base equals
the
origin/mainrecord. An autouse fixture fails any socket connection, sothe tests cannot reach UniProt or Europe PMC.
test_dry_run_default_writes_nothing--apply, in the temp tree or the repotest_apply_to_base_emits_exactly_the_committed_additionsNCBITaxon:405532, REVIEWED, entry v58 / seq v1, label-only), the committed edge, and one curation event with the writer's timestamp; nothing else in the record changestest_refuses_record_that_already_has_the_node--applyrefused, nothing writtentest_refuses_the_committed_recordtest_refuses_a_different_trait[False/True]traitmech:000220, dry run and applytest_refuses_unless_exactly_one_target_graph[renamed/duplicated]shedu_dna_end_nickinggraphtest_refuses_when_edge_object_node_is_missingtest_validation_failure_writes_nothingMutating the writer's entry version or its timestamp makes the round-trip test
fail, so it is not vacuous. Full suite: 3373 passed.
Second merge with
main#1817 landed and again conflicted on 13
pages/files; resolved byregeneration as before. #1817 also added a protein example (
P56947) withoutregenerating
reports/uniprot_grounding_audit.tsv, so after the merge thatreport was stale on this branch. It is regenerated (live, anonymous): the only
change is the
P56947row, which resolves clean. Againstmain, the reporttherefore differs by four rows:
B7HFR2,P06115andP56947added, and theA0A0F6B2U2HTTP 503 row resolved.Issues filed from the review
roleoverclaim above (fixed here; filed as the record).grounding_notes(fixed here), plus whetherREVIEWED_LABEL_ONLYnotes should name the search that was run.audit-uniprotexits 1 on 110 pre-existingENTRY_VERSION_MISMATCHrows; not fixed here, and the policy question is whether
entry_versionis apoint-in-time witness or a value to keep current. The report itself is now
regenerated and committed here (Shedu SduA PR: regenerate reports/uniprot_grounding_audit.tsv #1808).
the leads survive this PR's decision not to add them.
🤖 Generated with Claude Code