Skip to content

Add DS-24 system trait - #1425

Merged
realmarcin merged 1 commit into
mainfrom
add-ds24-system-trait
Sep 29, 2026
Merged

realmarcin merged 1 commit into
mainfrom
add-ds24-system-trait

Conversation

@realmarcin

Copy link
Copy Markdown
Contributor

Summary

  • mint traitmech:000449 for DS-24 system under phage defense system
  • add DOI, final Science supplement, and pinned DefenseFinder evidence for DS-24/RED2
  • keep the causal graph at nonmechanistic RED2 transcriptional-unit scope and record the native-host / PDDEXK / rule-level gap
  • reserve METPO:1040300 in proposals/metpo_traitmech_v326
  • regenerate pages, dashboard data, discussion search data, and audit reports

Primary Sources

  • DOI:10.1126/science.adv7924
  • NIHMS2163519-supplement-Table_S6.xlsx
  • NIHMS2163519-supplement-Table_S7.xlsx
  • NIHMS2163519-supplement-Table_S8.xlsx
  • pinned defense-finder-models List_system_article.md, Liste_hmm_system.md, and DefenseFinder_rules.tsv

Validation

  • .venv/bin/python -m py_compile scripts/add_ds_24_system_trait.py
  • .venv/bin/python scripts/verify_metpo_proposal.py proposals/metpo_traitmech_v326
  • .venv/bin/python scripts/verify_metpo_proposal.py --coverage
  • .venv/bin/python scripts/robot_validate_proposal.py proposals/metpo_traitmech_v326 --out /tmp/traitmech-robot-v326
  • .venv/bin/python scripts/validate_history_links.py history/records/ds_24_system
  • .venv/bin/linkml-validate --schema src/traitmech/schema/history.yaml --target-class HistoryRecord history/records/ds_24_system/2026-09-29T014502Z-codex-ds24.yaml
  • .venv/bin/python scripts/validate_strict.py data/traits/genomics/ds_24_system.yaml --out /tmp/traitmech-ds24-validation.tsv --workers 1 --quiet
  • .venv/bin/linkml-validate -s src/traitmech/schema/traitmech.yaml --target-class TraitRecord data/traits/genomics/ds_24_system.yaml
  • .venv/bin/python scripts/audit_proposals.py data/traits/genomics/ds_24_system.yaml --out /tmp/traitmech-ds24-proposals.tsv
  • .venv/bin/python scripts/audit_discussions_data.py
  • .venv/bin/python scripts/audit_discussion_anchors.py
  • .venv/bin/python scripts/audit_causal_graphs.py --out /tmp/traitmech-causal-graph-audit.tsv --connectivity-out /tmp/traitmech-causal-graph-connectivity.tsv
  • .venv/bin/python scripts/validate_strict.py --workers 4 --quiet
  • .venv/bin/python scripts/audit_graph_protein_taxa.py --fail-on gaps
  • .venv/bin/python scripts/audit_writers.py
  • .venv/bin/python -m pytest tests/test_readme_artifacts.py -q
  • .venv/bin/python scripts/audit_evidence_snippets.py
  • .venv/bin/python scripts/audit_exact_synonyms.py
  • .venv/bin/python scripts/audit_unapplied_groundings.py
  • .venv/bin/python scripts/audit_predicate_domains.py --fail-on new
  • .venv/bin/python scripts/pr_sanity.py
  • .venv/bin/ruff check src scripts tests
  • .venv/bin/pytest -q
  • git diff --check
  • .venv/bin/python scripts/audit_history_records.py --base origin/main

@culturebot-reviewer culturebot-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. This follows the DS-2..DS-23 template closely and everything I could check offline holds up.

Verified

  • traitmech:000449 is unused elsewhere in the corpus and is the next ID after traitmech:000448 (DS-23). Parent traitmech:000209 exists and its label matches the phage_defense_system graph node's grounding.
  • Predicates are grounded per mappings/predicate_grounding.tsv: RO:0002326 "contributes to" (subject/object types open) and METPO:2007700" "confers" (BIOLOGICAL_PROCESS subject → TRAIT object is explicitly permitted). rdfs:subClassOf` is standard.
  • Graph structure is sound: 4 declared nodes, 3 edges, every edge subject/object resolves to a declared node, one connected component and 0 orphans (matches the regenerated app/dashboard/priority.json row). Every edge carries evidence, which the schema requires.
  • No collisions: RED2, WP_000183405.1, NZ_QOYT01000030.1, and the DS-24 synonym appear nowhere else under data/, and METPO:1040300 is reserved only by the new v326 cohort. The METPO:1016300 parent placeholder is the same one 20+ prior phage-defense cohorts use.
  • Internal cross-consistency of the quoted rows is good: Table S6 coordinates 4612–5400 (789 nt = 262 codons + stop) agree with the 262.0 aa length in the Table S8 HHpred row, and WP_000183405.1 is the same accession across S6, S8, and the proposal.
  • history/records/ds_24_system/2026-09-29T014502Z-codex-ds24.yaml is present, and curation_history carries both the mint and the canonical-example-gap event. Derived artifacts (README counts, pages/, priority.json, app/discussions/data.js, the three reports/ files) are all regenerated consistently rather than hand-patched.
  • scripts/add_ds_24_system_trait.py goes through write_validated_trait and record_curation_event, and gates writes behind --apply.
  • Keeping the graph NONMECHANISTIC is the right call given the PDDEXK HHpred hit is a structural prediction, not a demonstrated activity; scope_notes and the open KNOWLEDGE_GAP discussion name that limit accurately, including the absent DefenseFinder rule row.

What I could not check here, stated plainly rather than implied: this environment has no network access and no permission to execute Python, so I could not fetch the Science supplement tables or the pinned defense-finder-models files to confirm the snippets are byte-for-byte verbatim, and I could not run just qc / validate_strict.py. The snippets are structurally identical in shape and field order to the 23 merged sibling records, and the Liste_hmm_system.md row's column widths match, but the verbatim check itself rests on CI and on the validation list in the PR description.

@realmarcin
realmarcin added this pull request to the merge queue Sep 29, 2026
Merged via the queue into main with commit e735270 Sep 29, 2026
8 checks passed
@realmarcin
realmarcin deleted the add-ds24-system-trait branch September 29, 2026 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant