Repository navigation
Add DS-24 system trait - #1425
Merged
Merged
Conversation
There was a problem hiding this comment.
Approving. This follows the DS-2..DS-23 template closely and everything I could check offline holds up.
Verified
traitmech:000449is unused elsewhere in the corpus and is the next ID aftertraitmech:000448(DS-23). Parenttraitmech:000209exists and itslabelmatches thephage_defense_systemgraph node's grounding.- Predicates are grounded per
mappings/predicate_grounding.tsv:RO:0002326"contributes to" (subject/object types open) andMETPO:2007700" "confers" (BIOLOGICAL_PROCESS subject → TRAIT object is explicitly permitted).rdfs:subClassOf` is standard. - Graph structure is sound: 4 declared nodes, 3 edges, every edge subject/object resolves to a declared node, one connected component and 0 orphans (matches the regenerated
app/dashboard/priority.jsonrow). Every edge carriesevidence, which the schema requires. - No collisions:
RED2,WP_000183405.1,NZ_QOYT01000030.1, and theDS-24synonym appear nowhere else underdata/, andMETPO:1040300is reserved only by the new v326 cohort. TheMETPO:1016300parent placeholder is the same one 20+ prior phage-defense cohorts use. - Internal cross-consistency of the quoted rows is good: Table S6 coordinates 4612–5400 (789 nt = 262 codons + stop) agree with the 262.0 aa length in the Table S8 HHpred row, and
WP_000183405.1is the same accession across S6, S8, and the proposal. history/records/ds_24_system/2026-09-29T014502Z-codex-ds24.yamlis present, andcuration_historycarries both the mint and the canonical-example-gap event. Derived artifacts (README counts,pages/,priority.json,app/discussions/data.js, the threereports/files) are all regenerated consistently rather than hand-patched.scripts/add_ds_24_system_trait.pygoes throughwrite_validated_traitandrecord_curation_event, and gates writes behind--apply.- Keeping the graph
NONMECHANISTICis the right call given the PDDEXK HHpred hit is a structural prediction, not a demonstrated activity;scope_notesand the openKNOWLEDGE_GAPdiscussion name that limit accurately, including the absent DefenseFinder rule row.
What I could not check here, stated plainly rather than implied: this environment has no network access and no permission to execute Python, so I could not fetch the Science supplement tables or the pinned defense-finder-models files to confirm the snippets are byte-for-byte verbatim, and I could not run just qc / validate_strict.py. The snippets are structurally identical in shape and field order to the 23 merged sibling records, and the Liste_hmm_system.md row's column widths match, but the verbatim check itself rests on CI and on the validation list in the PR description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
traitmech:000449forDS-24 systemunderphage defense systemMETPO:1040300inproposals/metpo_traitmech_v326Primary Sources
DOI:10.1126/science.adv7924NIHMS2163519-supplement-Table_S6.xlsxNIHMS2163519-supplement-Table_S7.xlsxNIHMS2163519-supplement-Table_S8.xlsxdefense-finder-modelsList_system_article.md,Liste_hmm_system.md, andDefenseFinder_rules.tsvValidation
.venv/bin/python -m py_compile scripts/add_ds_24_system_trait.py.venv/bin/python scripts/verify_metpo_proposal.py proposals/metpo_traitmech_v326.venv/bin/python scripts/verify_metpo_proposal.py --coverage.venv/bin/python scripts/robot_validate_proposal.py proposals/metpo_traitmech_v326 --out /tmp/traitmech-robot-v326.venv/bin/python scripts/validate_history_links.py history/records/ds_24_system.venv/bin/linkml-validate --schema src/traitmech/schema/history.yaml --target-class HistoryRecord history/records/ds_24_system/2026-09-29T014502Z-codex-ds24.yaml.venv/bin/python scripts/validate_strict.py data/traits/genomics/ds_24_system.yaml --out /tmp/traitmech-ds24-validation.tsv --workers 1 --quiet.venv/bin/linkml-validate -s src/traitmech/schema/traitmech.yaml --target-class TraitRecord data/traits/genomics/ds_24_system.yaml.venv/bin/python scripts/audit_proposals.py data/traits/genomics/ds_24_system.yaml --out /tmp/traitmech-ds24-proposals.tsv.venv/bin/python scripts/audit_discussions_data.py.venv/bin/python scripts/audit_discussion_anchors.py.venv/bin/python scripts/audit_causal_graphs.py --out /tmp/traitmech-causal-graph-audit.tsv --connectivity-out /tmp/traitmech-causal-graph-connectivity.tsv.venv/bin/python scripts/validate_strict.py --workers 4 --quiet.venv/bin/python scripts/audit_graph_protein_taxa.py --fail-on gaps.venv/bin/python scripts/audit_writers.py.venv/bin/python -m pytest tests/test_readme_artifacts.py -q.venv/bin/python scripts/audit_evidence_snippets.py.venv/bin/python scripts/audit_exact_synonyms.py.venv/bin/python scripts/audit_unapplied_groundings.py.venv/bin/python scripts/audit_predicate_domains.py --fail-on new.venv/bin/python scripts/pr_sanity.py.venv/bin/ruff check src scripts tests.venv/bin/pytest -qgit diff --check.venv/bin/python scripts/audit_history_records.py --base origin/main