Repository navigation
fix(config): drop dead show_context, complete manifest --schema, record directory versions - #30
Merged
Merged
Conversation
…rd directory versions - notification_settings.show_context was read by no code: removed from the template and baseline, added to DROPPED_KEYS so migration deletes it. - manifest --schema now covers audio_files, terminal_sequence, include_user_email and statusline_settings; tests/test_manifest_drift.py fails when a template key is missing from it or a dropped key is still in it. - AGENTS.md names tests/test_manifest_drift.py as a guard. - docs/DIRECTORY_LISTING.md, docs/PROJECT_STATUS.md: every push to master becomes a held directory version (portal, 2026-10-21), correcting the 2026-10-04 one-minute observation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #29, which left three items open.
notification_settings.show_contextwas in the template but read by no code. It is removed fromconfig/default_preferences.json,config/_defaults_baseline.jsonand the tracked sample, and added toDROPPED_KEYS, somigrate(or the next hook) deletes it and reports it underremoved[]. Checked by hand: a file withshow_context: falseandmode: audio_onlymigrates to noshow_context,modekept.manifest --schemanow describesaudio_files,notification_settings.terminal_sequence,webhook_settings.include_user_emailandstatusline_settings, and no longer describesshow_context.config/user_preferences.schema.jsonregenerated. Two new tests intests/test_manifest_drift.py: every template key is in the schema (down to where it stops listingproperties), and noDROPPED_KEYSentry is. Run against the old schema they fail on 10 keys.AGENTS.mdnamestests/test_manifest_drift.pyas the guard for flags and config keys.master(14 so far), including two docs-only pushes. That corrects the 2026-10-04 note that a docs-only push created no version. Updated indocs/DIRECTORY_LISTING.mdanddocs/PROJECT_STATUS.md.Verification
python -m unittest discover tests:Ran 814 tests … OK (skipped=2)bash scripts/build-plugin.sh --check:{"ok":true,"in_sync":true,"checked":207}🤖 Generated with Claude Code