Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The TMY reader cannot be instantiated and references undefined names, while ASCII Grid row counting and CSV dataset serialization also produce incorrect results.
3 open issues
What changed in this PR
Adds an ESRI ASCII Grid reader to dsprofile’s format-based profiling system, with a sample dataset and tests. The branch also includes CSV support and retains the deferred TMY reader.
Changes:
- Adds ASCII Grid header parsing, row counts, companion-file detection, and reader registration.
- Adds CSV reading and documents both new CLI formats.
- Adds logging compatibility fallbacks and ignores generated local files.
| File | Description |
|---|---|
tests/test_ascii_grid.py |
Tests reader initialization and profile output. |
tests/data/sample.asc |
Provides a small ASCII Grid fixture. |
README.md |
Documents CSV and ASCII Grid commands. |
dsprofile/utils/log.py |
Adds a logging-level lookup fallback. |
dsprofile/main.py |
Uses compatible logging-level lookup for CLI validation. |
dsprofile/lib/tmy.py |
Adds the deferred, unfinished TMY reader. |
dsprofile/lib/csv.py |
Adds CSV loading and CLI integration. |
dsprofile/lib/ascii_grid.py |
Implements ASCII Grid parsing and profiling. |
dsprofile/lib/__init__.py |
Registers CSV and ASCII Grid readers through imports. |
.gitignore |
Excludes build, coverage, cache, and environment files. |
Review effort: Balanced
| from pvlib.iotools import read_tmy3 | ||
|
|
||
| #subclass | ||
| class TMYReader(Reader): |
| sys.exit(1) | ||
| continue | ||
|
|
||
| data_rows += 1 |
|
|
||
| def process(self): | ||
| return { | ||
| "dataset": str(self.dataset) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addition of ascii grid reader and tests. tmy reader remains on this branch but a merge with the csv branch should see it deleted.