Repository navigation
Conversation
…e test host Part of upstream's .NET 11 preparation (cherry-picked there from App-vNext/Polly#2931). Only test results such as the CI JUnit reports move; coverage keeps its explicit --coverage-output path. Refs #66 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U6RM4Rd2HejEcaWDY3qovL
…OnHalfOpened Test-only. Adds upstream's OnActionPreExecute_HalfOpen_OnHalfOpenedNotCompleted_WaitsForCompletion. Refs #66 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U6RM4Rd2HejEcaWDY3qovL
iancooper
requested review from
DevJonny,
holytshirt and
preardon
as code owners
October 25, 2026 15:13
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of App-vNext/Polly@3ab3ec00 (App-vNext/Polly#3285, which cherry-picks part of App-vNext/Polly#2931, upstream's .NET 11 SDK update). Upstream sync #3, tracked in #66.
Changes
eng/Test.targets: stop passing--results-directoryto the MTP test host. This is upstream's patch unchanged.CircuitStateControllerTests: add upstream'sOnActionPreExecute_HalfOpen_OnHalfOpenedNotCompleted_WaitsForCompletion. It's test-only, the name already followsMember_Scenario_Outcome, and it's applied from upstream's patch with the rename.They're separate commits, build config and then test, following Tidy First.
What else relies on the results directory?
cake.cs, the workflows and ADR 0004's divergences don't readartifacts/tests.--coverage-outputpath, soartifacts/coverage/<Project>/coverage.<tfm>.xmldoesn't change, and neither do the per-TFM reports (divergence 5) or the threshold check (divergence 1). I checked this locally after the change.<Project>.<tfm>.junit.xml). On the .NET 10.0.401 SDK it now goes to MTP's default./TestResults/instead ofartifacts/tests/. Both paths are gitignored, and no workflow uploads the JUnit files. The GitHub reporting (--report-github) doesn't use a file.So no divergence is needed.
Verification
Paramore.Fences.Core.Tests: 782/782 pass in Release on net10.0, net9.0 and net8.0.Refs #66
🤖 Generated with Claude Code
https://claude.ai/code/session_01U6RM4Rd2HejEcaWDY3qovL