Skip to content

Sample finish_uploading_large_file uses the wrong sha1 and fails its resume check #249

Open

Description

@sophiecarreras

What happens

The finish_uploading_large_file sample command sets the content source's sha1 from largeFileVersion.getContentSha1(). For a large file the server reports none there, while the resume check compares the source sha1 with the stored large_file_sha1 info value. The check then rejects the resume with a mismatch error.

Where

samples/src/main/java/com/backblaze/b2/sample/B2.java:576-579 (.setSha1(largeFileVersion.getContentSha1())); the check is at core/src/main/java/com/backblaze/b2/client/B2LargeFileUploader.java:127; the SDK itself notes that sha1 is none for large files at core/src/main/java/com/backblaze/b2/client/contentHandlers/B2ContentWriter.java:152.

Why it matters

Impact: Docs and messages (a sample command that does not work), loud. Severity: Low, because it only affects a sample command and fails with a clear error, and nothing is harmed.

How to check

Found by reading the code, not reproduced. Read the sample and the check: the check compares against getLargeFileSha1OrNull(), but the sample passes getContentSha1(). Using getLargeFileSha1OrNull() or computing the sha1 from the local file would match.

Version

Seen at v6.5.0. Present on the default branch: present.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions