Repository navigation
[eno][tombstone-recovery 6/7] Clean up inventory Secrets on Composition deletion - #664
Merged
Ruinan Liu (ruinan-liu) merged 3 commits intoOct 21, 2026
Conversation
Ruinan Liu (ruinan-liu)
force-pushed
the
users/ruinanliu/ruinanliu/backup-5-inventory-record
branch
from
October 13, 2026 20:07
cf3920f to
214fa64
Compare
Ruinan Liu (ruinan-liu)
force-pushed
the
users/ruinanliu/backup-6-inventory-deletion
branch
from
October 13, 2026 20:16
4ad869a to
a753aed
Compare
Ruinan Liu (ruinan-liu)
changed the base branch from
users/ruinanliu/ruinanliu/backup-5-inventory-record
to
main
October 16, 2026 05:15
Ruinan Liu (ruinan-liu)
force-pushed
the
users/ruinanliu/backup-6-inventory-deletion
branch
from
October 16, 2026 05:16
a753aed to
97ac26a
Compare
Ruinan Liu (ruinan-liu)
marked this pull request as ready for review
October 16, 2026 05:17
Ruinan Liu (ruinan-liu)
requested review from
Robbie Zhang (robbiezhang),
Tingting Liu (tilnl) and
xiazhan
as code owners
October 16, 2026 05:17
xiazhan
reviewed
Oct 18, 2026
Ruinan Liu (ruinan-liu)
left a comment
Collaborator
Author
There was a problem hiding this comment.
Respond to comment
xiazhan
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delete a Composition's inventory Secrets from the downstream cluster's
kube-systemnamespace when the Composition is deleted while its Symphony is not being deleted.Behavior
cleanupInventoryas a tombstone recovery operation selected byselectTombstoneRecoveryOperation.eno.azure.io/recovery-enabled: "true"), and it has aDeletionTimestamp.eno.azure.io/inventory-lineagelabel and delete all of them, across every synthesis UUID and chunk.NotFoundcounts as deleted.CurrentSynthesis.Reconciled.Safety
eno.azure.io/symphony-deleting: "true"; Symphony deletion orphans downstream resources.kube-system.Limitations and Scope