Repository navigation
Route tests by backend marks and isolate test databases - #70
Open
nicoloesch wants to merge 2 commits into
Open
nicoloesch wants to merge 2 commits into
nicoloesch wants to merge 2 commits into
Conversation
3 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sqlitevec,pgvector,duckdbvssandfaissname the infrastructure a test needs and select the CI job, and the fixtures pass the matchingrouting_mark, so a test without it fails at setup.db_dialect,unitandintegration. A test with a routing mark needs infrastructure and a test without one needs none. The tests that open a SQLite database carrysqlitevec.BackendTypewithBACKEND_PARAMS, and each param carries its routing mark. DuckDB VSS gains tests for the metrics it supports.--strict-markersis set, theDialectenum replaces string literals, and ruffTID251bans inline engines in tests.pytest.importorskipis gone, because CI installs every extra. The pgvector 0.8 test now fails on an older pgvector instead of skipping.ci.ymladds the nodb job and abuild-test-faissjob. The sqlite job runssqlitevec and not pgvector, because the bundle test uses both backends and runs in the postgres job.Checklist
breaking,feature,fix,dependencies, orchore)uv run pytest -q)uv run ruff check .)