Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merged owner decision accepts a conditional Juffa licensing interpretation but leaves scope and final wording open. Prepare a concrete review packet outside production packaging: the proposed three-function source/compiled boundary, exact new third-party section and full native NOTICE, unmodified official CC BY-SA 4.0 text, POM license/comment template, and exact README/release-note paragraph.
Pin every candidate file’s raw bytes in review.json, together with the source header hashes, revision mappings, reviewed owner-decision merge and supporting evidence digests. Preserve the accepted distinction: MIT for Apple/MLX contributions and the direct CC offer for Juffa’s expression, with no CC adapter’s license identified and (B)’s condition retained as the counterargument. The proposed combined-binary boundary remains an owner judgment.
The POM comment deliberately retains one approved-notice permalink token. Its wording/substitution rule can be reviewed now, but the literal final URL/POM must follow an earlier approved notice commit, ancestry/raw-section checks and final metadata review. The manifest explicitly marks scope, wording and release readiness unapproved. Merge of this preparation PR alone does not supply those substantive decisions.
No production notice, POM, inventory, audit status, native code, RC1 bytes or historical evidence changes. After approval, the compliance proposal’s packaging/enforcement work and new-candidate verification remain necessary.
Validation: verified candidate/input hashes, owner record at its merge commit, both staged header hashes, exact notice title/separator/EOF and append behavior, POM template/token, all eight sections of the raw official license, publication paragraph equality, local links, prose/template column widths and git diff --check. Confirmed production and historical evidence are unchanged. No runtime tests were rerun for this unpackaged review material.