Repository navigation
Conversation
…e names
Presets tab: "Save all presets" reads P01..P80 with the new
PA_CMD_PA_PRESET (83, reply 0x63) and downloads one icarus-presets
.json; "Restore all presets" writes a file back through the preset
upload (target 0), reading each preset back to check it. EMPTY slots in
the file are left alone (a saved slot is never EMPTY); Onyx files are
refused, as the slots differ.
Capture names ("USER NAM" instead of the file name):
- the editor had one reply slot, and the 1.5 s live refresh could take
it mid-upload, so the new capture was not found and never renamed.
Requests now run one at a time.
- an upload to a given capture slot was stored under "USER NAM nn" and
matched by name, so replacing a renamed capture added a new one. It
now replaces in place, and the editor renames it from the new file.
- names were cut at the first dot ("JCM800 v1.5" -> "JCM800 v1"); only
a real file extension is dropped now, in the editor and the firmware.
Tests: test_editor_protocol (cmd 83, preset upload, bad CRC refused,
upload/rename/replace in place) and test_editor_page (the JSON round
trip in Node, a restore read back on the emulated unit).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ure-name fixes Bluetooth stays off in the package. QA gate (qa_gate.py --base main --release): READY FOR BENCH TEST, 83 pass, 0 fail. No hardware run is recorded for this image yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Editor: save and restore all presets (
b16341c)PA_CMD_PA_PRESET(83, reply0x63):[index]returns[index, status]plus the storedpa_preset_t(164 bytes; status 1 = no such preset). It is read only.icarus-presetsJSON file. Restore all presets writes it back through the existing preset upload (cmd 25, target 0) and reads each preset back to check it. EMPTY slots in the file are skipped, and Onyx files are refused because their slots differ.Captures keep their file names (
b16341c)clean_nam_name.Test fix
test_sysex_read.c:check_replyreturned a pointer into its own stack buffer, so the device-info text checks read dead stack memory. Oncesysex.cgrew, that turned into failures in the build. The buffer is nowstatic.Release (
9fe0ca6)release/Icarus_0.11was rebuilt with these changes. Bluetooth is off in the package.Testing
qa_gate.py --base main --release: READY FOR BENCH TEST, 83 pass, 0 fail.test_editor_protocol.py(cmd 83, preset upload, bad CRC refused, upload/rename/replace in place) andtest_editor_page.py(the JSON round trip in Node, and a restore read back on the emulated unit).For the reviewer
🤖 Generated with Claude Code