Repository navigation
Conversation
v0.1.1 was merged into main with nothing published under Releases: the release commit builds the package and commits it to custom-fw/release/Icarus_0.11/, but nothing ever created the tag or the GitHub release, and the repository had no .github/workflows directory at all, so there was no automation to do it. This workflow publishes a release when a v* tag is pushed. It resolves the package folder from the tag (v0.1.1 -> Icarus_0.11, the minor and patch digits concatenate into the firmware's two-digit minor), verifies SHA256SUMS, and creates the release with the assets. It publishes the committed package rather than rebuilding, because the firmware needs the proprietary JieLi pi32 toolchain (C:\\JL\\pi32), which the GitHub runners do not have. custom-fw\\build.ps1 does the build locally and the package is committed with the release commit. Also supports a manual run, and prefers a per-package RELEASE_NOTES.md when the package carries one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
v0.1.1was merged intomainwith nothing published under Releases. The release commit (5e50b71) builds the package and commits it tocustom-fw/release/Icarus_0.11/, but no tag was created and no GitHub release was made — and the repository had no.github/workflowsdirectory at all, so there was no automation to catch it.v0.1.1has now been tagged and published manually; this PR makes the next one automatic.What it does
On a push of a
v*tag (or a manual run):v0.1.1->Icarus_0.11,v0.1.0->Icarus_0.10,v1.0.5->1.05.SHA256SUMSagainst every listed file. A mismatch aborts the release — nothing is published.Why it publishes the committed package instead of rebuilding
The firmware is built with the proprietary JieLi pi32 toolchain (
C:\JL\pi32), which is not available on the GitHub-hosted runners, so CI cannot produce the.bin/.fwsc.custom-fw\build.ps1does the build locally and the package is committed with the release commit; this workflow publishes exactly that checksum-verified payload. The release process is documented in the header of the workflow file.Release process from now on
PA_FW_VERSIONincustom-fw/include/pa_config.h(11u->12umeans 0.12).custom-fw\build.ps1. It writescustom-fw/release/Icarus_<ver>/.SHA256SUMSwith the version bump.Pushing the tag publishes the release. A release commit can no longer land on
mainwith nothing published.Tested
v0.1.0andv0.1.1trees: both resolve to the right folder and the right four assets.