diff --git a/launch/core/platforms/linux.py b/launch/core/platforms/linux.py index bd87786..b859ab6 100644 --- a/launch/core/platforms/linux.py +++ b/launch/core/platforms/linux.py @@ -248,6 +248,16 @@ def _start_container( "cpu_quota": int(CPU_CORES * 100000), "mem_limit": MEM_LIMIT, } + # Keep Linux sandboxes least-privileged by default. Consumers that need + # a narrow Docker capability (for example, network-policy tests using + # iptables) can opt in through a comma-separated environment variable. + requested_capabilities = [ + capability.strip() + for capability in os.environ.get("SWE_BENCH_LIVE_DOCKER_CAP_ADD", "").split(",") + if capability.strip() + ] + if requested_capabilities: + run_kwargs["cap_add"] = requested_capabilities container = client.containers.run( image_name, diff --git a/tests/test_linux_docker_capabilities.py b/tests/test_linux_docker_capabilities.py new file mode 100644 index 0000000..2581ffd --- /dev/null +++ b/tests/test_linux_docker_capabilities.py @@ -0,0 +1,57 @@ +import os +import sys +from unittest.mock import MagicMock, patch + + +ROOT = os.path.dirname(os.path.dirname(__file__)) +sys.path.insert(0, ROOT) + +from launch.core.platforms.linux import LinuxRuntime + + +def _start_runtime(monkeypatch, capabilities=None): + captured = {} + + class FakeContainer: + def attach_socket(self, **_kwargs): + return object() + + class FakeContainers: + def run(self, *_args, **kwargs): + captured.update(kwargs) + return FakeContainer() + + class FakeClient: + containers = FakeContainers() + + def version(self): + return {"Os": "linux"} + + class FakeDocker: + def ping(self): + return True + + if capabilities is None: + monkeypatch.delenv("SWE_BENCH_LIVE_DOCKER_CAP_ADD", raising=False) + else: + monkeypatch.setenv("SWE_BENCH_LIVE_DOCKER_CAP_ADD", capabilities) + + with patch("launch.core.platforms.linux.docker.from_env", side_effect=[FakeDocker(), FakeClient()]), patch.object( + LinuxRuntime, "pull_image", return_value=None + ), patch.object(LinuxRuntime, "_clear_initial_prompt", return_value=None), patch.object( + LinuxRuntime, "send_command", return_value=MagicMock() + ): + LinuxRuntime._start_container("task-image", "task-id", 30, 1) + return captured + + +def test_linux_runtime_does_not_add_capabilities_by_default(monkeypatch): + captured = _start_runtime(monkeypatch) + + assert "cap_add" not in captured + + +def test_linux_runtime_passes_trimmed_opt_in_capabilities(monkeypatch): + captured = _start_runtime(monkeypatch, " NET_ADMIN, , NET_RAW ") + + assert captured["cap_add"] == ["NET_ADMIN", "NET_RAW"] \ No newline at end of file