Add smoke test for built image

tests/smoke.sh checks a built image under timeouts: non-interactive login
shells exit, help50 deps are installed, wrappers print with stdin redirected.
Run via make smoke, and in CI before pushing to Docker Hub.

Author: rongxin-liu

.github/workflows/main.yml

@@ -30,6 +30,13 @@ jobs:
             cs50/cli:amd64
             cs50/cli:canary-amd64
 
+      - name: Check out tests
+        uses: actions/checkout@v7
+
+      - name: Smoke-test linux/amd64 build
+        run: |
+          bash tests/smoke.sh cs50/cli:canary-amd64
+
       - name: Push linux/amd64 build to Docker Hub
         if: ${{ github.ref == 'refs/heads/main' }}
         run: |
@@ -68,6 +75,13 @@ jobs:
             cs50/cli:arm64
             cs50/cli:canary-arm64
 
+      - name: Check out tests
+        uses: actions/checkout@v7
+
+      - name: Smoke-test linux/arm64 build
+        run: |
+          bash tests/smoke.sh cs50/cli:canary-arm64
+
       - name: Push linux/arm64 build to Docker Hub
         if: ${{ github.ref == 'refs/heads/main' }}
         run: |

Makefile

@@ -13,7 +13,10 @@ rebuild:
 	docker build --build-arg VCS_REF=$(shell git rev-parse HEAD) --no-cache --tag $(IMAGE) .
 
 run:
-	docker run --env LANG=$(LANG) --env LOCAL_WORKSPACE_FOLDER="$(PWD)" --env WORKDIR=/mnt --interactive --publish-all --rm --security-opt seccomp=unconfined --tty --volume "$(PWD)":/mnt --volume /var/run/docker.sock:/var/run/docker-host.sock --workdir /mnt cs50/cli bash --login || true
+	docker run --env LANG=$(LANG) --env LOCAL_WORKSPACE_FOLDER="$(PWD)" --env WORKDIR=/mnt --interactive --publish-all --rm --security-opt seccomp=unconfined --tty --volume "$(PWD)":/mnt --volume /var/run/docker.sock:/var/run/docker-host.sock --workdir /mnt $(IMAGE) bash --login || true
+
+smoke:
+	bash tests/smoke.sh $(IMAGE)
 
 squash: depends
 	docker-squash --tag $(IMAGE) $(IMAGE)

tests/smoke.sh

@@ -0,0 +1,28 @@
+#!/bin/bash
+# Smoke-tests a built cs50/cli image. Usage: tests/smoke.sh [IMAGE]
+# Each check has a timeout so that a regression that hangs the shell fails loudly.
+
+set -o errexit -o nounset -o pipefail
+
+IMAGE="${1:-cs50/cli}"
+run() { timeout 60 docker run --rm "$@"; }
+
+echo "Checking $IMAGE"
+
+echo "- non-interactive login shell exits (help50 must not start without a terminal)"
+run "$IMAGE" bash --login -c 'echo ok' | grep -qx ok
+echo true | run --interactive "$IMAGE" bash --login
+
+echo "- runtime dependencies of help50 are installed"
+run "$IMAGE" bash --login -c 'for c in ansi2txt col file script fold; do command -v "$c" > /dev/null || { echo "missing $c" >&2; exit 1; }; done'
+
+echo "- help50 controller is the Bash version, on PATH, and enabled by default"
+run "$IMAGE" bash --login -c 'test "$(type -P help50)" = /opt/cs50/bin/help50 && help50 is-enabled && test "$(help50 status)" = stopped' > /dev/null
+
+echo "- wrappers print their message even when stdin is redirected"
+run "$IMAGE" bash --login -c 'valgrind python x.py < /dev/null; test $? -eq 1' 2>&1 | grep -q 'does not support Python'
+
+echo "- _fold wraps without a terminal"
+run "$IMAGE" bash --login -c '. /opt/cs50/lib/cli; TERM= _fold "$(printf "a %.0s" {1..100})"' | head -n 1 | grep -qE '^.{1,80}$'
+
+echo "OK"